Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Nil Pointer with JetstreamAPIPending #220

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Avoid Nil Pointer with JetstreamAPIPending #220

merged 2 commits into from
Oct 28, 2024

Conversation

samuelattwood
Copy link
Member

@samuelattwood samuelattwood commented Oct 28, 2024 •
edited
Loading

  • Fixes reference to sm.Stats.JetStream.Meta before nil check
  • Switched metric type to Gauge

ripienaar
ripienaar approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@samuelattwood samuelattwood merged commit c847275 into main Oct 28, 2024
4 checks passed
@samuelattwood samuelattwood deleted the sattwood/avoid-nil-pointer branch October 28, 2024 18:33
@ripienaar ripienaar mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

@sethjback sethjback Awaiting requested review from sethjback

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelattwood @ripienaar