Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request-deferred.el to fetch the query results #25

Merged
merged 1 commit into from
Jan 22, 2017

Conversation

galeo
Copy link
Contributor

@galeo galeo commented Jan 16, 2017

Hi @nathankot

I did some digging and it seems like the biggest bottleneck for company-sourcekit is actually the http response results being written into the sourcekit-output buffer. It takes a good ~2 seconds for 3k lines of output.

As you said, it may improve the performance without writing the query results into the *sourcekit-output* buffer. The code uses request-deferred.el to fetch the query results asynchronously and the returned response data is automatically parsed into JSON format. I also delete some code that becomes useless.

It may improve the performance without writing the query results
into the `*sourcekit-output*` buffer.
@nathankot
Copy link
Owner

@galeo

Thanks for the PR, this is awesome work 💯

Sorry for the slow responses (things have been really busy for me recently)

I checked out your branch and it is faster from my initial observations.
This also means we no longer depend on curl being available.

Lets see how this holds up as we go, I'll keep issue #24 open as there should be other places where gains can be made.

@nathankot nathankot merged commit 3286a0d into nathankot:master Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants