Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support add size BootstrapDialog.SIZE_FULL_SCREEN #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

helldone1986
Copy link

adding support new size of modal panel.
BootstrapDialog.SIZE_FULL_SCREEN - 80% of screen width

additonal need add style for modal-full-screen:

.modal-dialog.modal-full-screen{
min-width: 80%;
}

adding support new size of modal panel. 
BootstrapDialog.SIZE_FULL_SCREEN - 80% of screen width
@matusferko
Copy link

@helldone1986 If 80% is full screen what name would be for 90%? I suggest name change. maybe SIZE_80 ?
In that case you could add multiple new sizes ...

@helldone1986
Copy link
Author

@Coffy I believe that for a modal dialog width of more than 80% is meaningless - because it is not a modal dialog and complete coverage of the screen.
The name "SIZE_80" I feel a little informative, since "80" everyone can be interpreted in its own way.

Probably it is possible to change the "SIZE_FULL_SCREEN" to "SIZE_MAX_WIDTH"...
What do you think?

@matusferko
Copy link

It's your opinion @helldone1986
At the end it's up to @nakupanda and of course easy workaround is to add related css class in 'onshow' event handler to modal-dialog div.
But additional fluid/% sizes could be helpful.

@waspinator
Copy link

waspinator commented Aug 27, 2016

I mentioned a simialr idea in issue #264. The issue also has a jsfiddle example of the CSS changes needed.

http://jsfiddle.net/waspinator/6w2ofdby/

@arivera12
Copy link

arivera12 commented Mar 3, 2017

This may be the size property for definning a full width and height modal

BootstrapDialog.show({
message: 'Hi Apple!',
size: BootstrapDialog.SIZE_FULL
});
This are the css to make a full width and height bootstrap modal

.modal-dialog-full
{
width: 100%;
height: 100%;
padding: 0;
}
.modal-content-full
{
height: 100%;
border-radius: 0;
}

I open an issue over here #326

Update: @waspinator Your fiddle seems to be working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants