Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding amd support (RequireJS, NodeJS) #14

Merged
merged 2 commits into from
Feb 25, 2014

Conversation

AndrewEastwood
Copy link
Contributor

No description provided.

@nakupanda
Copy link
Owner

Getting started with RequireJS..

@AndrewEastwood
Copy link
Contributor Author

What do you think about this?
However I think it would be really cool to recommend this project for https://github.com/twbs/bootstrap-expo/issues/new.

@nakupanda
Copy link
Owner

Of course making it fits AMD is a good idea, I just would like to learn more about RequireJS first, your code will definitely be merged into bootstrap-dialog.js later.

Thank you :)

@AndrewEastwood
Copy link
Contributor Author

Additionally I've added a couple of shortcuts within request.

@AndrewEastwood
Copy link
Contributor Author

Alright. However what do you think about BS Expo?

@nakupanda
Copy link
Owner

Ah.. sorry for forgetting to let you know that I've tried posting bootstrap-dialog on BS Expo, see here: twbs/bootstrap-expo#770

@nakupanda
Copy link
Owner

Good news Andrew, BootstrapDialog now is in bs-expo's resources: http://expo.getbootstrap.com/resources/

Cheers :)

nakupanda added a commit that referenced this pull request Feb 25, 2014
adding amd support (RequireJS, NodeJS)
@nakupanda nakupanda merged commit 3d37911 into nakupanda:master Feb 25, 2014
@AndrewEastwood
Copy link
Contributor Author

Woohoo! :)

@nakupanda
Copy link
Owner

I've always been adding complete braces for any type of code block, for example,

if (there is banana) {
      Roar nice!
}

The reason of why I'm doing this is to make every single block of a program more readable.

So do you mind if I add complete braces to your contributed code?

Thanks.

@AndrewEastwood
Copy link
Contributor Author

I don't mind :)

Thanks

@nakupanda
Copy link
Owner

Hi, could you please take at look at this one #33 (comment) ?

Thanks :)

@nakupanda
Copy link
Owner

Hi @AndrewEastwood ,

Could you please give hand to review this #113?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants