-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding amd support (RequireJS, NodeJS) #14
Conversation
Getting started with RequireJS.. |
What do you think about this? |
Of course making it fits AMD is a good idea, I just would like to learn more about RequireJS first, your code will definitely be merged into bootstrap-dialog.js later. Thank you :) |
Additionally I've added a couple of shortcuts within request. |
Alright. However what do you think about BS Expo? |
Ah.. sorry for forgetting to let you know that I've tried posting bootstrap-dialog on BS Expo, see here: twbs/bootstrap-expo#770 |
Good news Andrew, BootstrapDialog now is in bs-expo's resources: http://expo.getbootstrap.com/resources/ Cheers :) |
adding amd support (RequireJS, NodeJS)
Woohoo! :) |
I've always been adding complete braces for any type of code block, for example,
The reason of why I'm doing this is to make every single block of a program more readable. So do you mind if I add complete braces to your contributed code? Thanks. |
I don't mind :) Thanks |
Hi, could you please take at look at this one #33 (comment) ? Thanks :) |
Hi @AndrewEastwood , Could you please give hand to review this #113? Thank you. |
No description provided.