Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Add universal Create Resource Menu #11564

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

r00gm
Copy link
Contributor

@r00gm r00gm commented Nov 5, 2024

Summary

image
image

image
image
image

Community

image

Related Linear tickets, Github issues, and Community forum posts

PAY-2001

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 5, 2024
@r00gm r00gm changed the title feat(editor): Add universal Crete Resource Menu feat(editor): Add universal Create Resource Menu Nov 5, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nents/N8nNavigationDropdown/NavigationDropdown.vue 87.50% 2 Missing ⚠️
...ditor-ui/src/components/Projects/ProjectHeader.vue 93.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

r00gm and others added 5 commits November 6, 2024 09:56
…sal-create-resource-button

# Conflicts:
#	packages/editor-ui/src/components/layouts/ResourcesListLayout.vue
#	packages/editor-ui/src/views/CredentialsView.vue
Copy link

cypress bot commented Nov 13, 2024

n8n    Run #7935

Run Properties:  status check failed Failed #7935  •  git commit 44e4c4c6f2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Project n8n
Branch Review pay-2001-add-universal-create-resource-button
Run status status check failed Failed #7935
Run duration 04m 17s
Commit git commit 44e4c4c6f2: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 r00gm 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 280
View all changes introduced in this branch ↗︎

Tests for review

Failed  34-template-credentials-setup.cy.ts • 1 failed test

View Output Video

Test Artifacts
Template credentials setup > Credential setup from workflow editor > should fill credentials from workflow editor Test Replay Screenshots Video
Failed  30-editor-after-route-changes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  6-code-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  11-inline-expression-editor.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  41-editors.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 49 specs in Cypress Cloud.

@cstuncsik cstuncsik self-requested a review November 14, 2024 13:01
cstuncsik
cstuncsik previously approved these changes Nov 14, 2024
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cstuncsik cstuncsik marked this pull request as ready for review November 15, 2024 10:14
cstuncsik
cstuncsik previously approved these changes Nov 15, 2024
Copy link
Contributor

Copy link
Contributor

✅ All Cypress E2E specs passed

cstuncsik
cstuncsik previously approved these changes Nov 15, 2024
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

cstuncsik
cstuncsik previously approved these changes Nov 15, 2024
Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants