-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(iroh-relay, netcheck): move tests to use local relays #2935
Open
divagant-martian
wants to merge
20
commits into
n0-computer:main
Choose a base branch
from
divagant-martian:expose-and-use-local-relay-testing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test(iroh-relay, netcheck): move tests to use local relays #2935
divagant-martian
wants to merge
20
commits into
n0-computer:main
from
divagant-martian:expose-and-use-local-relay-testing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
changed the title
add helper functions in the server
test(iroh-relay, netcheck): move tests to use local relays
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
netcheck
's dependency on staging relays, using locally served ones instead. This is necessary to move netcheck out without needing to find an appropriate place for the staging values to prevent circular dependeciesBreaking Changes
RelayMap
now can be created with an iterator ofArc
s directly.Notes & open questions
iroh-relay/src/server/testing.rs
was added by mistake in the split pr, so the deletions are not really picked by rust and all new code should be considered.. well, new.Change checklist
Documentation updates following the style guide, if relevant.Tests if relevant.All breaking changes documented.