Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(iroh-relay, netcheck): move tests to use local relays #2935

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

divagant-martian
Copy link
Contributor

@divagant-martian divagant-martian commented Nov 15, 2024

Description

Removes netcheck's dependency on staging relays, using locally served ones instead. This is necessary to move netcheck out without needing to find an appropriate place for the staging values to prevent circular dependecies

Breaking Changes

  • RelayMap now can be created with an iterator of Arcs directly.

Notes & open questions

  • a test was removed since it doesn't test properties of netcheck, it just connects to the staging relay
  • iroh-relay/src/server/testing.rs was added by mistake in the split pr, so the deletions are not really picked by rust and all new code should be considered.. well, new.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@divagant-martian divagant-martian changed the title add helper functions in the server test(iroh-relay, netcheck): move tests to use local relays Nov 15, 2024
@divagant-martian divagant-martian marked this pull request as ready for review November 15, 2024 21:52
@divagant-martian divagant-martian requested a review from a team November 15, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

1 participant