fix(iroh-net): reconfirm best addr when receiving data on it #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
approved these changes
Apr 30, 2024
| match self.0.as_mut() { | ||
| None => { | ||
| // Nothing to do | ||
| // TODO: do we want to store this regardless? |
There was a problem hiding this comment.
no, something else is supposed to set best-addr in that case. at least, i think so
|
nit, the description should probably describe what this fixes and why it fixes it instead of just relying on the issue link |
added more details to the description |
dignifiedquire
force-pushed
the
fix-conn-switching
branch
from
275ed5c
to
1112d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving data via UDP, we were not extending the validity of the current
best_addr. This would trigger expiry of thebest_addr, even though it was actively being used.This fix, extends the validity, everytime we successfully receive a UDP packet on the current
best_addr.Closes #2169