refactor: switch to hex #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-docs/pr/2/docs/iroh_docs/ Last updated: 2024-10-25T15:07:20Z |
rklaehn
reviewed
Nov 15, 2024
| @@ -296,7 +296,7 @@ impl LiveEvent { | |||
| /// engine. Changing the default author will not be persisted. | |||
| /// | |||
| /// If set to `Persistent`, the default author will be loaded from and persisted to the specified | |||
| /// path (as base32 encoded string of the author's public key). | |||
| /// path (as hex encoded string of the author's public key). | |||
There was a problem hiding this comment.
This will break existing installations, right? Not sure what the consequence is of the default author being not readable anymore.
There was a problem hiding this comment.
yeah, the future of this is unclear atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
Author,NamespaceandNamespaceSecrets are now encoded and parsed as hex instead of base32Ref n0-computer/iroh#2841