Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpanfile: Use url instead mirror for Geography::NationalGrid #5259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thibaultduponchelle
Copy link

Description

mirror => is failing (for carton install, not sure about carton install --deployment) with recent carton/cpanm and I doubt it works with old vendored carton neither.

I propose to replace per url => which is documented (mirror is documented but only with usage of dist along).

What do you think?

Please check the following:

  • Have you updated the changelog? If this is not necessary, put square brackets around this: [skip changelog]

@dracos
Copy link
Member

dracos commented Nov 18, 2024

I've just run our vendored carton on a fresh install with --deployment, and without --deployment and Geograph::NationalGrid installed in both cases, at least - I think it might use the snapshot information if present regardless?
(Separately, it looks like there's an issue with XML::LibXML needing upgrading).

Happy to change the line if it doesn't work with more recent versions though, of course, as long as it doesn't break our vendored version.

@thibaultduponchelle
Copy link
Author

thibaultduponchelle commented Nov 19, 2024

Yes it's using the cpanfile.snapshot infos even without --deployment

What gives you a clean run ./vendor/bin/carton install after removing local/ and cpanfile.snapshot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants