Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bexley ww container requests fixes 02 #5248

Draft
wants to merge 6 commits into
base: bexley-ww-container-requests-fixes
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

Please check the following:

  • Has the code POD documentation been added or updated?
  • Whether this PR should include changes to any public documentation, or the FAQ;
  • All cobrand-specific commits start their commit message with the cobrand in square brackets;
  • Is new functionality tested? CodeCov will warn you about the diff coverage, but won’t complain about e.g. new files;
  • Will cobrand-specific changes require additional work to ensure consistent behaviour on www.fixmystreet.com?
  • Are the changes tested for accessibility?
  • Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog

Please check the contributing docs, and describe your pull request here.
Screenshots or GIF animations (using e.g. LICEcap) may be helpful.

Please include any issues that are fixed, using "fixes" or "closes" so that
they are auto-closed when the PR is merged.

Thanks for contributing!

Also renamed final 'submit' to reflect that request is not just
for new containers.
@nephila-nacrea nephila-nacrea changed the base branch from master to bexley-ww-container-requests November 11, 2024 11:43
@nephila-nacrea nephila-nacrea changed the base branch from bexley-ww-container-requests to bexley-ww-container-requests-fixes November 11, 2024 11:43
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-fixes branch from 93fab66 to e5d59b7 Compare November 11, 2024 11:44
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.51%. Comparing base (5bb8860) to head (0c1c290).
Report is 4 commits behind head on bexley-ww-container-requests-fixes.

Files with missing lines Patch % Lines
perllib/FixMyStreet/Cobrand/Bexley/Waste.pm 90.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           bexley-ww-container-requests-fixes    #5248   +/-   ##
===================================================================
  Coverage                               82.51%   82.51%           
===================================================================
  Files                                     410      410           
  Lines                                   32304    32312    +8     
  Branches                                 5169     5169           
===================================================================
+ Hits                                    26656    26663    +7     
- Misses                                   4125     4126    +1     
  Partials                                 1523     1523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-fixes-02 branch from bcdf2a9 to 0c1c290 Compare November 11, 2024 19:46
@nephila-nacrea nephila-nacrea force-pushed the bexley-ww-container-requests-fixes branch from e98782f to cd50694 Compare November 11, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant