-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bexley ww container requests fixes 02 #5248
Draft
nephila-nacrea
wants to merge
6
commits into
bexley-ww-container-requests-fixes
Choose a base branch
from
bexley-ww-container-requests-fixes-02
base: bexley-ww-container-requests-fixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bexley ww container requests fixes 02 #5248
nephila-nacrea
wants to merge
6
commits into
bexley-ww-container-requests-fixes
from
bexley-ww-container-requests-fixes-02
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed final 'submit' to reflect that request is not just for new containers.
nephila-nacrea
changed the base branch from
master
to
bexley-ww-container-requests
November 11, 2024 11:43
nephila-nacrea
changed the base branch from
bexley-ww-container-requests
to
bexley-ww-container-requests-fixes
November 11, 2024 11:43
nephila-nacrea
force-pushed
the
bexley-ww-container-requests-fixes
branch
from
November 11, 2024 11:44
93fab66
to
e5d59b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bexley-ww-container-requests-fixes #5248 +/- ##
===================================================================
Coverage 82.51% 82.51%
===================================================================
Files 410 410
Lines 32304 32312 +8
Branches 5169 5169
===================================================================
+ Hits 26656 26663 +7
- Misses 4125 4126 +1
Partials 1523 1523 ☔ View full report in Codecov by Sentry. |
…form We had not handled cases where the container has a 'parent' (i.e. wheelie bin with different size options), nor handled removal options.
nephila-nacrea
force-pushed
the
bexley-ww-container-requests-fixes-02
branch
from
November 11, 2024 19:46
bcdf2a9
to
0c1c290
Compare
nephila-nacrea
force-pushed
the
bexley-ww-container-requests-fixes
branch
from
November 11, 2024 19:51
e98782f
to
cd50694
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following:
Please check the contributing docs, and describe your pull request here.
Screenshots or GIF animations (using e.g. LICEcap) may be helpful.
Please include any issues that are fixed, using "fixes" or "closes" so that
they are auto-closed when the PR is merged.
Thanks for contributing!