Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Island Roads] Default 'CONFIRM Subject' to be a blank selection #5188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nephila-nacrea
Copy link
Contributor

A 'Please select' option with a blank value is added under every group header in the dropdown; this is selected by default (under the relevant header) to force the admin user to choose a triage category (rather than it defaulting to the first category in the group).

[skip changelog]

Screenshot 2024-09-25 at 14 54 00

A 'Please select' option with a blank value is added under every
group header in the dropdown; this is selected by default (under the
relevant header) to force the admin user to choose a triage
category (rather than it defaulting to the first category in the
group).
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.61%. Comparing base (0291878) to head (9e5465d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5188      +/-   ##
==========================================
+ Coverage   82.49%   82.61%   +0.11%     
==========================================
  Files         406      406              
  Lines       31723    31990     +267     
  Branches     5048     5110      +62     
==========================================
+ Hits        26171    26428     +257     
- Misses       4062     4071       +9     
- Partials     1490     1491       +1     
Flag Coverage Δ
82.61% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but almost all of the two halves of the IF are the same, so can we have a much smaller IF inside? It looks to me you only need to change the inmost option-related bit. IF IoW, print out blank; and the existing selected IF could be dropped entirely I think, as that only applies for IoW.
Also stick a required on the <select> (in general, that can be I think) :)

@nephila-nacrea nephila-nacrea force-pushed the island-roads-blank-triage-category branch from 9a015c7 to c3c9d74 Compare September 26, 2024 11:28
@nephila-nacrea
Copy link
Contributor Author

This looks good, but almost all of the two halves of the IF are the same, so can we have a much smaller IF inside? It looks to me you only need to change the inmost option-related bit. IF IoW, print out blank; and the existing selected IF could be dropped entirely I think, as that only applies for IoW. Also stick a required on the <select> (in general, that can be I think) :)

@dracos Not sure I did it in quite the way you asked but it's compact and seems to work :-) Also added some tests.

@nephila-nacrea nephila-nacrea force-pushed the island-roads-blank-triage-category branch from c3c9d74 to 9e5465d Compare September 26, 2024 13:22
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yep, looks good :)

@nephila-nacrea nephila-nacrea self-assigned this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants