Increase network read timeout when sending transactions #17
+15
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to my previous pull request #15 that I accidentally closed by rebasing my fork.
These changes increase the network read timeout to 5 minutes when sending transactions to avoid timing out too early when exchanging a slate with a device that takes longer than a few seconds to generate a reply.
The 5 minute timeout is now only applied when sending a
receive_tx
request, and all other request types will still use the existing default read timeout. This will avoid any unnecessary waiting since acheck_version
request always comes before areceive_tx
request.