-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better homology #166
base: master
Are you sure you want to change the base?
Better homology #166
Conversation
mtsch
commented
Apr 3, 2024
- Improvements to the homology algorithm:
- compute infinite intervals by tracking potential birth simplex candidates.
- use these candidates to stop the reduction early if possible.
- Some code reorganization.
@test ripserer( | ||
Rips(cycle; threshold=2); alg=:homology, implicit=true | ||
)[2][1] == (1.0, Inf) | ||
@test_broken ripserer( | ||
@test ripserer( | ||
Rips, cycle; alg=:homology, threshold=2, implicit=false | ||
)[2][1] == (1.0, Inf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
@test ripserer( | |
Rips(cycle; threshold=2); alg=:homology, implicit=true | |
)[2][1] == (1.0, Inf) | |
@test_broken ripserer( | |
@test ripserer( | |
Rips, cycle; alg=:homology, threshold=2, implicit=false | |
)[2][1] == (1.0, Inf) | |
@test ripserer(Rips(cycle; threshold=2); alg=:homology, implicit=true)[2][1] == | |
(1.0, Inf) | |
@test ripserer(Rips, cycle; alg=:homology, threshold=2, implicit=false)[2][1] == | |
(1.0, Inf) |
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Benchmark resultJudge resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsA ratio greater than
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfoTarget
Baseline
Target resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Baseline resultBenchmark Report for /home/runner/work/Ripserer.jl/Ripserer.jlJob Properties
ResultsBelow is a table of this job's results, obtained by running the benchmarks.
Benchmark Group ListHere's a list of all the benchmark groups executed by this job:
Julia versioninfo
Runtime information
|
Pull Request Test Coverage Report for Build 8545078607Details
💛 - Coveralls |