WIP: Make RegFifoTxBaseAddr and RegFifoRxBaseAddr registers use configurable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akloboucnik
changed the title
In LoRa::new these are set to 0 which is not default (RegFifoTxBaseAddr is 0x80 after reset). This however cannot be modified after LoRa structure creation - so e.g. in LoRa::configure it cannot be configured back to the same value (0) as in LoRa::new.
akloboucnik
force-pushed
the
make-fifo-base-addr-configurable
branch
from
b49fa4c
to
586adb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LoRa::new these are set to 0 which is not default (RegFifoTxBaseAddr
is 0x80 after reset). This however cannot be modified after LoRa
structure creation - so e.g. in LoRa::configure it cannot be configured
back to the same value (0) as in LoRa::new.