Minimizing config file #1983
Draft
Minimizing config file #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+18
to
+19
| days_lookup: int = 365, | ||
| max_days_in_cache: int = 7 |
There was a problem hiding this comment.
In reference to #1437 (comment), both days_lookup and max_days_in_cache are used outside the auto_nag/scripts directory:
- https://github.com/mozilla/relman-auto-nag/blob/941e19a8a23a180bf8a5080c4dfed40537846049/auto_nag/bzcleaner.py#L82
- https://github.com/mozilla/relman-auto-nag/blob/941e19a8a23a180bf8a5080c4dfed40537846049/auto_nag/bzcleaner.py#L188
Refactoring these is a bit less straightforward, so let us keep it outside the scope of this pull request.
There was a problem hiding this comment.
Got it. Since they are used outside the directory, I should remove them from the init function, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress to solve #1437
Checklist
to-be-announcedtag added if this is worth announcing