Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend documentation of directories setting #74

Merged
merged 5 commits into from
Mar 11, 2023
Merged

Extend documentation of directories setting #74

merged 5 commits into from
Mar 11, 2023

Conversation

orontee
Copy link
Contributor

@orontee orontee commented Feb 14, 2023

Relates to #38

kingosticks
kingosticks reviewed Feb 19, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
kingosticks
kingosticks reviewed Feb 19, 2023
View reviewed changes
README.rst Outdated Show resolved Hide resolved
kingosticks
kingosticks requested changes Feb 19, 2023
View reviewed changes
Copy link
Member

@kingosticks kingosticks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful, thank you. Saves everyone looking through the code and/or banging their head against a wall.

@orontee
Copy link
Contributor Author

orontee commented Feb 20, 2023

Thanks for your suggestions. I'll rework this at the end of the week, I don't have access to a computer for few days.

@orontee orontee force-pushed the extend-directories-documentation branch from 1c4e156 to 3ba421c Compare February 26, 2023 13:38
@orontee
Copy link
Contributor Author

orontee commented Feb 26, 2023

The proposed change has been rebased on master, you suggestions taken into account and I made some rewording. A wrong URI has been corrected too.

jodal
jodal approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@jodal jodal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small errors I found.

Could you also add the Library layout header to the table of contents up top?

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
orontee and others added 3 commits March 11, 2023 13:18
@jodal
Copy link
Member

jodal commented Mar 11, 2023

Thanks for taking the time and effort to document this properly!

@jodal jodal merged commit 179bb05 into mopidy:master Mar 11, 2023
@orontee orontee deleted the extend-directories-documentation branch August 27, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingosticks kingosticks kingosticks requested changes

@jodal jodal jodal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orontee @jodal @kingosticks