Remove unneeded storage version from pallet invulnerables #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not unneeded, it makes running migrations a bit more robust |
WASM runtime size check:Compared to target branchdancebox runtime: 1416 KB (no changes) ✅ flashbox runtime: 832 KB (no changes) ✅ dancelight runtime: 1968 KB (no changes) ✅ container chain template simple runtime: 1096 KB (no changes) ✅ container chain template frontier runtime: 1392 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master tomasz-no-storage-version +/- ##
=============================================================
+ Coverage 65.25% 65.30% +0.05%
Files 302 302
Lines 52728 52728
=============================================================
+ Hits 34403 34430 +27
- Misses 18325 18298 -27
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: make sure this doesn't break anything