Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S22C500 smoke test #3030

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Fix S22C500 smoke test #3030

merged 4 commits into from
Nov 5, 2024

Conversation

Agusrodri
Copy link
Contributor

What does it do?

Fixes the following error for staking rewards S22C500 smoke test (line 623):

📁 S22C500 rewards are given as expected
Error: Number can only safely store up to 53 bits
 - /moonbeam/node_modules/.pnpm/[email protected]/node_modules/bn.js/lib/bn.js:6:21
 - /moonbeam/node_modules/.pnpm/[email protected]/node_modules/bn.js/lib/bn.js:547:7
 - /suites/smoke/test-staking-rewards.ts:623:51
 - /suites/smoke/test-staking-rewards.ts:358:7
 - /suites/smoke/test-staking-rewards.ts:349:9

Also, smoke test configs for Alphanet and Stagenet were updated to use the proper endpoints at the moment of running smoke tests locally.

@Agusrodri Agusrodri added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2260 KB (no changes) ✅

Moonbeam runtime: 2228 KB (no changes) ✅

Moonriver runtime: 2232 KB (no changes) ✅

Compared to latest release (runtime-3300)

Moonbase runtime: 2260 KB (+232 KB compared to latest release) ⚠️

Moonbeam runtime: 2228 KB (+232 KB compared to latest release) ⚠️

Moonriver runtime: 2232 KB (+240 KB compared to latest release) ⚠️

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Coverage Report

@@                     Coverage Diff                      @@
##           master   agustin-fix-smoke-rewards     +/-   ##
============================================================
  Coverage   79.01%                      79.01%   0.00%     
  Files         305                         305             
  Lines       88447                       88447             
============================================================
  Hits        69878                       69878             
  Misses      18569                       18569             
Files Changed Coverage

Coverage generated Tue Nov 5 21:14:48 UTC 2024

@pLabarta pLabarta merged commit e635b34 into master Nov 5, 2024
39 checks passed
@pLabarta pLabarta deleted the agustin-fix-smoke-rewards branch November 5, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants