[MOON-2092] Implement call state override for eth_call #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbaztec
commented
Mar 7, 2023
nbaztec
commented
Mar 13, 2023
| B: BlockT, | ||
| C: StorageProvider<B, sc_service::TFullBackend<B>>, | ||
| { | ||
| type AddressMapping = M; |
There was a problem hiding this comment.
The presence of different address schemes introduces another generic parameter M to most of the service build code. We have the option to mark it as concrete in the EthDeps config struct to avoid that.
nbaztec
changed the title
nbaztec
commented
Mar 13, 2023
| /// Implements a default runtime storage override. | ||
| /// It assumes that the balances and nonces are stored in pallet `system.account`, and | ||
| /// have `nonce: Index` = `u32` for and `free: Balance` = `u128`. | ||
| pub struct DefaultEthereumRuntimeStorageOverride<M>(pub std::marker::PhantomData<M>); |
There was a problem hiding this comment.
This default may or may not be super useful as we ourselves are using AccountId20 while frontier is targetting AccountId32. The basic pallet system override might be trivial to copy paste from the template instead.
librelois
reviewed
Mar 13, 2023
nbaztec
commented
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements call state override for
eth_call.