Use apiextensions.k8s.io/v1 instead of apiextensions.k8s.io/v1beta1 #27
+99
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanel
reviewed
Feb 15, 2023
| to produced Service objects CoreDNS can watch this label and decide | ||
| to rewrite DnsName -> clusterIP' | ||
| type: boolean | ||
| ipOverride: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to get started with the repository I noticed to issues:
make run. I changed make run to address this.error: resource mapping not found for name: "externalservices.egress.monzo.com" namespace: "" from "STDIN": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1". This is because that API has been dropped since k8s 1.22. I'm not sure if you want to keep supporting older version, but thought I'd still make the suggestion. In this PR, I'm switching tov1fromv1beta1.After these changes,
make runsuccessfully starts the controller.