Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detached with relay control #1011

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bmpalmeida
Copy link

I've tried to do a initial effort for targeting #147, specially on having the single click controlling the relay without relying on HomeKit.

I've created a new input mode, detached with relay control, and i tied the single click to the relay.

I've tried to make it very clean, and maybe there are some limitation, but i've tested in 1PM and 2.5 and its working as expected.

@andyblac
Copy link
Collaborator

andyblac commented Jun 25, 2022

just a suggestion but to have a new button type called "DetachedWithRelay" is not the way to go, as the button is no longer detached, maybe you could simply add a check box to "Momentary" button type options to add extra HomeKit button options, maybe call the check box "Advanced button options" or "HomeKit Buttons"

@bmpalmeida
Copy link
Author

Hi Andy, completely agree. Let me try to do it.

@bmpalmeida
Copy link
Author

Hi, i've just pushed a new version with the HomeKit button option.

I'm now stuck on one question, which i think its important to make this clean.

I'm using stateless switch, but it has its own input inverted, hap type, etc. i think i should create and HomeKit button class, and synchornize the options with the momentary switch, what do you think? its the best way to go?

@andyblac
Copy link
Collaborator

andyblac commented Nov 4, 2022

Sorry for long delay in replying, ye sounds good to me, @rojer what do you think?

@AlexDavidenko
Copy link

Hi Guys,
Any update on this?

@grgmll
Copy link

grgmll commented Apr 7, 2023

Hi,
is it possible to have the firmaware to flash?
Thanks

@lorenzomorandini
Copy link

I totally expected this to already be in the firmware when I started using it. @timoschilling do you think it could be merged? Do you need any kind of help with it?

@mattewre
Copy link

mattewre commented Nov 8, 2023

Interesting feature. I hope it will be merged.

@bmpalmeida
Copy link
Author

@markirb any chance to include this functionality? should i follow this last approach and merge the code?

@markirb
Copy link
Collaborator

markirb commented Jul 13, 2024

Yes. Can you please resolve conflicts with a rebase? I will review then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants