Change onCleanup regex #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current regex only fixes the last ampersand within modx tags with multiple properties being set. This takes a different approach, not attempting to focus in on content within opening/closing double brackets but rather on the parameter format itself (which is highly unlikely to be used in normal text). This would also allow for ampersands within nested tags to be easily converted too, sidestepping the need for an overly-complex regex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current regex only fixes the last ampersand within modx tags with multiple properties being set. This takes a different approach, not attempting to focus in on content within opening/closing double brackets but rather on the parameter format itself (which is highly unlikely to be used in normal text). This would also allow for ampersands within nested tags to be easily converted too, sidestepping the need for an overly-complex regex.