This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would also be nice to look at adding categories to feeds and feed items. I haven't really tested how they look in actual readers, but they should be a good way to show users what versions and loaders an item has and filter by them of course, if feed readers support that
setResponseHeader(event, 'Content-Type', 'application/feed+json') | ||
return feed.json1() | ||
default: | ||
setResponseStatus(event, 500) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 500? This is not a server error
Superseded by #1225 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds RSS, Atom and JSON2 feeds to the frontend.
Routes
/feed/:feed_type/project/:project_id
where:feed_type
is eitherrss
,atom
orjson
and where:project_id
is the ID of the project./feed/:feed_type/notifications
where:feed_type
is eitherrss
,atom
orjson
and the user's authentication token is passed via theAuthentication
header.