Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix big integer case. #374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix big integer case. #374

wants to merge 1 commit into from

Conversation

jeanbone
Copy link

use lossless json with decimal to unmarshal & marshal big integer object.

@mobz
Copy link
Owner

mobz commented Dec 4, 2017

Hi This looks like an interesting solution to a problem many people have. Your PR has a few issues;

  • The _site directly is generated from the src directory - your changes need to be in the src directory also. You should set up the development toolchain as per instructions.
  • There also needs to be a build step to move the dependencies from node_modules into the _site directory - so the repo can be checked out clean and built. Alternatively copy decimal and lossless json into the vendor directory and do no use npm.

Let me know if you need more help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants