Wrap Node.js server with tini in Docker image #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot stop elasticsearch-head Docker container gracefully, because Node.js in Docker container cannot handle kernel signal (
SIGINT
,SIGTERM
and so on).https://github.com/nodejs/docker-node/blob/078ff84cb756df33fe3444090914e65a0721c9fd/docs/BestPractices.md#handling-kernel-signals
To handle these signals, we have to wrap Node.js process with lightweight init system, for example tini, or use
docker run --init
flag.However, Kubernetes does not support this flag.
I added some steps to install tini in elasticsearch-head Docker image. All Docker users will be able to stop gracefully by this change.