Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Add support for fNIRS data #365

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

rob-luke
Copy link
Member

@rob-luke rob-luke commented Jun 4, 2021

Hi, would you like to add support for fNIRS to mne-bids-pipeline?

This is an issue as PR. And allowed me to understand this package and determine what would be needed for it to run well with fNIRS data. It has the following issues to be addressed before a review is appropriate:

AKA this PR is a total house of cards. But if its here and public I won't lose it and maybe it will be useful to someone else why I tick off the points above. Things are stabilising now, so I will come back to this soon.

@rob-luke
Copy link
Member Author

rob-luke commented Jun 4, 2021

Using the pipeline from this PR I get nice reports and the following decoding performance on my tapping data for tapping with left hand vs tapping with right hand...

image

FYI: @agramfort @larsoner

Edit: fixed filtering issue in example after suggestion by @agramfort

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good @rob-luke 👍

@hoechenberger hoechenberger marked this pull request as draft June 16, 2021 19:58
@larsoner
Copy link
Member

larsoner commented Oct 3, 2022

@rob-luke we should come back to this -- now that I'm more familiar with mne-bids-pipeline I think it wouldn't be too bad to get this working. Do you want to try a new PR with the latest file structure? If you don't have time I could take a stab at it

@rob-luke
Copy link
Member Author

rob-luke commented Oct 4, 2022

we should come back to this

Agreed!

My plan of attack here is:

  • Get fNIRS BIDS officially merged (should happen in coming days)
  • Update MNE-BIDS to meet merged BIDS spec for fNIRS and add recommended fields
  • Tackle this PR in MNE-BIDS-Pipeline

Do you want to try a new PR with the latest file structure? If you don't have time I could take a stab at it

If you want to take a stab at this, then go wild :) I will be doing the items above in that order unless there is a reason not too.

@rob-luke
Copy link
Member Author

rob-luke commented Oct 7, 2022

FYI. fNIRS is now merged into BIDS main. So I will move on to adding complete support in MNE-BIDS.

@larsoner
Copy link
Member

larsoner commented Oct 7, 2022

Go go go @rob-luke 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants