No registering embedded and default-free obj_free candidates #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests failed once, with details described in #113. I restarted the CI test to see if it is reproducible. |
|
The CI tests passed, but the Immix plan took a bit longer (35 min, longer than MarkSweep which took 26 min) than expected to run test-all. I guess it may hit some pathological use cases when splitting the work packet. |
The C part of the binding no longer registers embedded and default-free RTypedData instances as obj_free candidates.
wks
force-pushed
the
feature/non-candidate-rtypeddata
branch
from
ffc720f
to
e0e1109
Compare
wks
changed the title
|
I changed this PR to only include the Ruby-side update about embedded and default-free RTypedData, and hope it only has minimal impact on the performance because it strictly reduces the amount of work to do. I'll merge the change about parallelizing obj_free candidate processing in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
rubyrepo which include a change that we no longer register embedded RTypedData that uses "default free" as candidates ofobj_free.