Bump the revision of mmtk-core and ruby repos #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated mmtk-core to fix a race that caused GC workers to sometimes observe copied objects not having VO bits. See: mmtk/mmtk-core#1214 The ruby repo is merged with the official master branch. Fixes: mmtk#106
|
|
|
When running locally, I observed that the heap size grew too slowly when using puts "Creating the hash..."
hash = {}
puts "Preparing the hash..."
("aaaa".."matz").each_with_index do |s, i|
hash[s] = i
end
puts "Doing the eval..."
begin
eval "class C; @@h = #{hash.inspect}; end"
end
puts "Done. Goodbye!"Here is a log when using MarkSweep, using the default dynamic heap size setting that ranges from 2M to 80% total physical memory (which is hardly reachable). The heap size increases slowly while preparing the hash, and stays almost the same while evaluating. The problems is, the heap size doesn't increase fast enough. After each GC, it only increases the heap size by a small amount, while the heap consists of mostly live objects. Therefore, the next GC will happen very soon. As a result, it triggers GC way too often, and each GC costs, especially for slow GC algorithms like MarkSweep. The command line arguments If we change to a fixed heap size (such as 100M), that test case will finish very quickly. The following is what happens when using a fixed 80M heap size. I chose to use dynamic heap size exactly because it triggers GC very often, which can be used to stress the GC. But for |
Run bootstraptest/test_eval.rb with a fixed heap size.
wks
force-pushed
the
update/merge-2024-10-10
branch
from
34f2b61
to
08a7e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated mmtk-core to fix a race that caused GC workers to sometimes observe copied objects not having VO bits. See:
mmtk/mmtk-core#1214
The ruby repo is merged with the official master branch.
Fixes: #106