Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk 47 with memiavl #10

Closed
wants to merge 30 commits into from
Closed

sdk 47 with memiavl #10

wants to merge 30 commits into from

Conversation

mmsqe
Copy link
Owner

@mmsqe mmsqe commented Jun 28, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 28, 2023
View reviewed changes
versiondb/client/convert_to_sst.go Fixed Show fixed Hide fixed
versiondb/client/convert_to_sst.go Fixed Show fixed Hide fixed
versiondb/client/changeset.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 29, 2023
View reviewed changes
app/app.go
Comment on lines +869 to +916
for acc := range maccPerms {
blockedAddrs[authtypes.NewModuleAddress(acc).String()] = !allowedReceivingModAcc[acc]
}

Check failure

Code scanning / gosec

the value in the range statement should be _ unless copying a map: want: for key := range m Error

expected either an append, delete, or copy to another map in a range with a map
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2023
View reviewed changes
memiavl/db.go Outdated
if err != nil {
return 0, err
}
return walVersion(lastIndex, uint32(metadata.InitialVersion)), nil

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe changed the base branch from evm_develop to main July 25, 2023 03:04
@mmsqe mmsqe force-pushed the evm_develop_47 branch 2 times, most recently from 01a56ce to 35fc9a0 Compare July 25, 2023 03:15
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 25, 2023
View reviewed changes
x/cronos/client/cli/tx.go
txHash = res.Hash.String()
}

parsedLogs, _ := sdk.ParseABCILogs(res.DeliverTx.Log)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning

Returned error is not propagated up the stack.
x/cronos/client/cli/tx.go
txHash = res.Hash.String()
}

parsedLogs, _ := sdk.ParseABCILogs(res.CheckTx.Log)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning

Returned error is not propagated up the stack.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 25, 2023
View reviewed changes
app/app.go
Comment on lines +914 to +916
for acc := range maccPerms {
blockedAddrs[authtypes.NewModuleAddress(acc).String()] = !allowedReceivingModAcc[acc]
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 25, 2023
View reviewed changes
versiondb/tsrocksdb/store.go Outdated
defer batch.Destroy()

var ts [TimestampSize]byte
binary.LittleEndian.PutUint64(ts[:], uint64(version))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
versiondb/client/restore.go Outdated
}
}()

return versionDB.Import(int64(height), ch)

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
versiondb/client/restore.go Outdated
return err
}

snapshot, chChunks, err := store.Load(height, uint32(format))

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion Error

Potential integer overflow by integer type conversion
@mmsqe mmsqe closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang