Skip to content

Commit

Permalink
CompatHelper: bump compat for Optimization to 4, (keep existing compa…
Browse files Browse the repository at this point in the history
…t) (#209)

* CompatHelper: bump compat for Optimization to 4, (keep existing compat)

* Bump OptimizationOptimJl compat

* Increase tolerance for HMC comparisons

* Increment patch version number

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Seth Axen <[email protected]>
  • Loading branch information
3 people authored Oct 25, 2024
1 parent 02989d0 commit 65c5646
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Pathfinder"
uuid = "b1d3bc72-d0e7-4279-b92f-7fa5d6d2d454"
authors = ["Seth Axen <[email protected]> and contributors"]
version = "0.9.2"
version = "0.9.3"

[deps]
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
Expand Down Expand Up @@ -50,8 +50,8 @@ LogDensityProblems = "2.1.0"
LogDensityProblemsAD = "1.7.0"
MCMCChains = "6.0.2"
Optim = "1.7.2"
Optimization = "3.16.0"
OptimizationOptimJL = "0.1.7, 0.2, 0.3"
Optimization = "3.16.0, 4"
OptimizationOptimJL = "0.1.7, 0.2, 0.3, 0.4"
PDMats = "0.11.26"
PSIS = "0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9"
ProgressLogging = "0.1.4"
Expand Down
2 changes: 1 addition & 1 deletion test/integration/AdvancedHMC/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function mean_and_mcse(θs)
return ms, ses
end

function compare_estimates(xs1, xs2, α=0.05)
function compare_estimates(xs1, xs2, α=0.01)
nparams = length(first(xs1))
α /= nparams # bonferroni correction
p = α / 2
Expand Down
2 changes: 1 addition & 1 deletion test/integration/DynamicHMC/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function mean_and_mcse(θs)
return ms, ses
end

function compare_estimates(xs1, xs2, α=0.05)
function compare_estimates(xs1, xs2, α=0.01)
nparams = first(size(xs1))
α /= nparams # bonferroni correction
p = α / 2
Expand Down

2 comments on commit 65c5646

@sethaxen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/118084

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.9.3 -m "<description of version>" 65c56465b91b4acfeb9d19132b8b47104b14c14f
git push origin v0.9.3

Please sign in to comment.