Fixed compiler warnings

mkulesh · Oct 28, 2020 · 06acfde · 06acfde
1 parent d80f761
commit 06acfde
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 22 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -1,12 +1,12 @@
 apply plugin: 'com.android.application'
 
 android {
-    compileSdkVersion 30
+    compileSdkVersion 29
     buildToolsVersion "29.0.3"
     defaultConfig {
         applicationId "com.mkulesh.mmd"
         minSdkVersion 16
-        targetSdkVersion 30
+        targetSdkVersion 29
         versionCode 10
         versionName "1.10"
         setProperty("archivesBaseName", "mmd-v" + versionName)
@@ -22,7 +22,7 @@ android {
     lintOptions {
         checkReleaseBuilds false
         abortOnError false
-        disable "RtlHardcoded", "RtlSymmetry", "RtlEnabled", "ApplySharedPref", "PrivateResource", "SetTextI18n", "DefaultLocale"
+        disable "RtlHardcoded", "RtlSymmetry", "RtlEnabled", "ApplySharedPref", "PrivateResource", "SetTextI18n", "DefaultLocale", "ClickableViewAccessibility"
     }
 
     compileOptions {

diff --git a/app/src/main/java/com/mkulesh/mmd/MainActivity.java b/app/src/main/java/com/mkulesh/mmd/MainActivity.java
@@ -14,7 +14,6 @@
 
 package com.mkulesh.mmd;
 
-import android.annotation.SuppressLint;
 import android.content.Intent;
 import android.content.pm.PackageManager;
 import android.content.res.Configuration;
@@ -82,7 +81,6 @@ public class MainActivity extends AppCompatActivity
             R.drawable.snow_flake, R.drawable.ufo_cartoon_style, R.drawable.whirlpool
     };
 
-    @SuppressLint("RestrictedApi")
     @Override
     protected void onCreate(Bundle savedInstanceState)
     {
@@ -219,7 +217,6 @@ public boolean onOptionsItemSelected(@NonNull MenuItem menuItem)
      * Navigation drawer
      *********************************************************/
 
-    @SuppressLint("RestrictedApi")
     private BaseFragment getVisibleFragment()
     {
         FragmentManager fragmentManager = MainActivity.this.getSupportFragmentManager();

diff --git a/app/src/main/java/com/mkulesh/mmd/config/WallpaperSettingsActivity.java b/app/src/main/java/com/mkulesh/mmd/config/WallpaperSettingsActivity.java
@@ -14,9 +14,6 @@
 
 package com.mkulesh.mmd.config;
 
-import android.annotation.SuppressLint;
-
-@SuppressLint("ExportedPreferenceActivity")
 public class WallpaperSettingsActivity extends SettingsActivity
 {
 

diff --git a/app/src/main/java/com/mkulesh/mmd/fragments/Experiment.java b/app/src/main/java/com/mkulesh/mmd/fragments/Experiment.java
@@ -35,7 +35,7 @@ public class Experiment implements Runnable, Parcelable
      * State attributes to be stored in Parcel
      */
     static final String PARCELABLE_ID = "Experiment";
-    private AtomSet atomSet = new AtomSet(); // set of the atoms, must be always handled as synchronized
+    private final AtomSet atomSet; // set of the atoms, must be always handled as synchronized
 
     /**
      * Parcelable interface
@@ -44,7 +44,7 @@ private Experiment(Parcel in)
     {
         super();
         ViewUtils.Debug(this, "created from parcel");
-        readFromParcel(in);
+        atomSet = in.readParcelable(AtomSet.class.getClassLoader());
     }
 
     @Override
@@ -59,11 +59,6 @@ public void writeToParcel(Parcel dest, int flags)
         dest.writeParcelable(atomSet, flags);
     }
 
-    private void readFromParcel(Parcel in)
-    {
-        atomSet = in.readParcelable(AtomSet.class.getClassLoader());
-    }
-
     public static final Parcelable.Creator<Experiment> CREATOR = new Parcelable.Creator<Experiment>()
     {
         public Experiment createFromParcel(Parcel in)
@@ -103,6 +98,7 @@ public Experiment(Context context)
         super();
         this.context = context;
         ViewUtils.Debug(this, "created from scratch");
+        atomSet = new AtomSet();
         readParameters(context);
     }
 

diff --git a/app/src/main/java/com/mkulesh/mmd/model/AtomSet.java b/app/src/main/java/com/mkulesh/mmd/model/AtomSet.java
@@ -161,12 +161,17 @@ public AtomSet(AtomSet set)
         atomRadius = set.atomRadius;
         atomMass = set.atomMass;
         gravity = set.gravity;
+        thermalChange = set.thermalChange;
+        timeStep = set.timeStep;
+        energyNorm = set.energyNorm;
+        boundaryCondition = set.boundaryCondition;
         ePotenz = set.ePotenz;
         eKinetic = set.eKinetic;
         temperature = set.temperature;
         atomImage = set.atomImage;
         pauseHandler = set.pauseHandler;
         calculationTime = set.calculationTime;
+        solver = null;
     }
 
     /**

diff --git a/app/src/main/java/com/mkulesh/mmd/utils/ViewUtils.java b/app/src/main/java/com/mkulesh/mmd/utils/ViewUtils.java
@@ -14,7 +14,6 @@
 
 package com.mkulesh.mmd.utils;
 
-import android.annotation.SuppressLint;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Canvas;
@@ -78,7 +77,6 @@ public static Bitmap drawViewToBitmap(View view, Rect infoRect)
     /**
      * Procedure hows toast that contains description of the given button
      */
-    @SuppressLint("RtlHardcoded")
     public static boolean showButtonDescription(Context context, View button)
     {
         CharSequence contentDesc = button.getContentDescription();

diff --git a/app/src/main/java/com/mkulesh/mmd/widgets/FloatingButtonsSet.java b/app/src/main/java/com/mkulesh/mmd/widgets/FloatingButtonsSet.java
@@ -14,7 +14,6 @@
 
 package com.mkulesh.mmd.widgets;
 
-import android.annotation.SuppressLint;
 import android.content.Context;
 import android.util.AttributeSet;
 import android.view.Gravity;
@@ -40,7 +39,6 @@ public FloatingButtonsSet(Context context, AttributeSet attrs)
         prepare();
     }
 
-    @SuppressLint("RtlHardcoded")
     private void prepare()
     {
         setOrientation(HORIZONTAL);

diff --git a/app/src/main/java/com/mkulesh/mmd/widgets/VerticalSeekBar.java b/app/src/main/java/com/mkulesh/mmd/widgets/VerticalSeekBar.java
@@ -14,7 +14,6 @@
 
 package com.mkulesh.mmd.widgets;
 
-import android.annotation.SuppressLint;
 import android.content.Context;
 import android.content.res.TypedArray;
 import android.graphics.Canvas;
@@ -80,7 +79,6 @@ protected synchronized void onMeasure(int widthMeasureSpec, int heightMeasureSpe
         setMeasuredDimension(getMeasuredHeight(), getMeasuredWidth());
     }
 
-    @SuppressLint("ClickableViewAccessibility")
     @Override
     public boolean onTouchEvent(MotionEvent event)
     {