Adding support for vectorized hfmm3d calls
#74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for vectorized calls to `hfmm3d`. As mentioned by Manas Rachh the speedup is limited around batches of sizes 16-32 so the multiplication is done in batches.
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 48.76% 48.16% -0.61%
==========================================
Files 38 38
Lines 3488 3536 +48
==========================================
+ Hits 1701 1703 +2
- Misses 1787 1833 +46
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support vectorized
hfmm3dcalls. As mentioned by Manas Rachh the calls should be done in batches of around 16-32 densities at a time.