Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add management api to check querycoord balance status #37784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #37783

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 18, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 79.66102% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.66%. Comparing base (00edec2) to head (7f1cf7a).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/ops_services.go 45.45% 10 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37784       +/-   ##
===========================================
+ Coverage   68.91%   80.66%   +11.75%     
===========================================
  Files         290     1357     +1067     
  Lines       25471   190977   +165506     
===========================================
+ Hits        17553   154051   +136498     
- Misses       7918    31487    +23569     
- Partials        0     5439     +5439     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.85% <ø> (-0.07%) ⬇️
Go 83.18% <79.66%> (∅)
Files with missing lines Coverage Δ
internal/distributed/querycoord/client/client.go 96.85% <100.00%> (ø)
internal/distributed/querycoord/service.go 77.20% <100.00%> (ø)
internal/proxy/management.go 87.44% <100.00%> (ø)
internal/util/mock/grpc_querycoord_client.go 94.87% <100.00%> (ø)
internal/querycoordv2/ops_services.go 85.75% <45.45%> (ø)

... and 1070 files with indirect coverage changes

---- 🚨 Try these New Features:

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants