Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: reduce copy of bitset and id conversion of brurtforce search #37675

Merged
merged 1 commit into from
Nov 19, 2024
Merged

enhance: reduce copy of bitset and id conversion of brurtforce search #37675

merged 1 commit into from
Nov 19, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Nov 14, 2024 •
edited
Loading

issue: #37798

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Nov 14, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

@cqy123456 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.59%. Comparing base (e9391ac) to head (6544d03).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/SearchBruteForce.cpp 95.12% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37675      +/-   ##
==========================================
- Coverage   80.68%   80.59%   -0.09%     
==========================================
  Files        1357     1356       -1     
  Lines      190831   191083     +252     
==========================================
+ Hits       153974   154011      +37     
- Misses      31436    31626     +190     
- Partials     5421     5446      +25
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.53% <96.82%> (-0.32%) ⬇️
Go 83.17% <100.00%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/QueryResult.h 98.18% <ø> (+2.94%) ⬆️
internal/core/src/query/SearchOnGrowing.cpp 97.50% <100.00%> (-0.07%) ⬇️
internal/core/src/query/SearchOnSealed.cpp 100.00% <100.00%> (ø)
internal/core/src/query/helper.h 100.00% <ø> (ø)
internal/core/src/query/SearchBruteForce.cpp 80.85% <95.12%> (+1.78%) ⬆️

... and 43 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 14, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@sunby
Copy link
Contributor

sunby commented Nov 15, 2024

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 16, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 18, 2024
@mergify mergify bot removed the ci-passed label Nov 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@cqy123456
Copy link
Contributor Author

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007 czs007 added this to the 2.5.0 milestone Nov 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 19, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 19, 2024
@sre-ci-robot sre-ci-robot merged commit 8216345 into milvus-io:master Nov 19, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@sunby sunby

@czs007 czs007

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cqy123456 @sunby @czs007 @sre-ci-robot