Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: optimize brurtforce search implement #37798

Open
3 of 4 tasks
cqy123456 opened this issue Nov 19, 2024 · 1 comment
Open
3 of 4 tasks

[Enhancement]: optimize brurtforce search implement #37798

cqy123456 opened this issue Nov 19, 2024 · 1 comment
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@cqy123456
Copy link
Contributor

cqy123456 commented Nov 19, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

task:

  • remove the bitset copy if row count % 8 != 0;

  • remove knowhere default id and outer id convert；

  • knowhere do the real fp16/bf16 search, get rid of memory copy

Why is this needed?

No response

Anything else?

No response
@cqy123456 cqy123456 added the kind/enhancement Issues or changes related to enhancement label Nov 19, 2024
@cqy123456 cqy123456 mentioned this issue Nov 19, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 19, 2024
@cqy123456
enhance: reduce copy of bitset and id conversion of brurtforce search (…
8216345 
…#37675)

issue: #37798

Signed-off-by: cqy123456 <[email protected]>
@xiaofan-luan
Copy link
Collaborator

impressive improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cqy123456 @xiaofan-luan