-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing db_name
param to the describeCollection()
#373
Conversation
…atabase is not passed to `describeCollection` function
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rashgaroth The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @rashgaroth! It looks like this is your first PR to milvus-io/milvus-sdk-node 🎉 |
please remove these lock files. |
This reverts commit 9c4d8e5.
done @shanghaikid |
Description
I've got an error when search with the specific db name, the error is :
Cannot read properties of undefined (reading nq)
, that's because the codeData.ts
does not passing thedb_name
parameterSummary
This pull request to
milvus/grpc/Data.ts
includes changes to improve the handling of collection requests in thesearch
method. The most important changes include importing theDescribeCollectionReq
type and modifying thesearch
method to use a default collection request.Improvements to collection request handling:
milvus/grpc/Data.ts
: Added theDescribeCollectionReq
import to support type checking for collection requests.milvus/grpc/Data.ts
: Modified thesearch
method to use a defaultdescribeCollectionRequest
object and conditionally add thedb_name
if present in the request.