Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support passing certificate buffer #336

Merged
merged 1 commit into from
Jul 5, 2024
Merged

support passing certificate buffer #336

merged 1 commit into from
Jul 5, 2024

Conversation

shanghaikid
Copy link
Contributor

relate #334

Signed-off-by: ryjiang <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.62%. Comparing base (0db18b2) to head (bfbb62c).

Files Patch % Lines
milvus/grpc/BaseClient.ts 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   96.72%   96.62%   -0.11%     
==========================================
  Files          43       43              
  Lines        2655     2663       +8     
  Branches      653      661       +8     
==========================================
+ Hits         2568     2573       +5     
- Misses         81       84       +3     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit 8d85324 into main Jul 5, 2024
2 of 5 checks passed
@shanghaikid shanghaikid deleted the node-334 branch July 5, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants