Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add resource group declarative api #313

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Conversation

shanghaikid
Copy link
Contributor

Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (4d1ede0) to head (fdec0ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files          43       43           
  Lines        2644     2644           
  Branches      651      651           
=======================================
  Hits         2562     2562           
  Misses         76       76           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit b1a2cd0 into main Jun 4, 2024
3 of 4 checks passed
@shanghaikid shanghaikid deleted the resource_group branch June 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants