Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 26036 #215

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix issue 26036 #215

merged 1 commit into from
Aug 3, 2023

Conversation

nameczz
Copy link
Collaborator

@nameczz nameczz commented Aug 3, 2023

related issue: milvus-io/milvus#26036
before:
image
after:
image

Signed-off-by: nameczz <[email protected]>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #215 (db6f04f) into main (ca9fdcb) will decrease coverage by 0.59%.
Report is 15 commits behind head on main.
The diff coverage is 92.59%.

❗ Current head db6f04f differs from pull request most recent head 9018bbc. Consider uploading reports for the commit 9018bbc to get more accurate results

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   96.82%   96.24%   -0.59%     
==========================================
  Files          32       32              
  Lines        1573     1596      +23     
  Branches      373      381       +8     
==========================================
+ Hits         1523     1536      +13     
- Misses         47       57      +10     
  Partials        3        3              
Files Changed Coverage Δ
milvus/types/Collection.ts 100.00% <ø> (ø)
milvus/grpc/Data.ts 95.97% <84.61%> (-2.89%) ⬇️
milvus/const/Milvus.ts 100.00% <100.00%> (ø)
milvus/grpc/User.ts 100.00% <100.00%> (ø)
milvus/utils/Format.ts 98.71% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nameczz, shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shanghaikid shanghaikid merged commit acfcd4d into main Aug 3, 2023
2 checks passed
@shanghaikid shanghaikid deleted the issue-26036 branch August 3, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants