fix: delete entities when the primary key is string (#214)

Signed-off-by: Yicai Yu <[email protected]>
milvus-io · Aug 2, 2023 · 2feccb4 · 2feccb4
1 parent a1dd6c8
commit 2feccb4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/milvus/grpc/Data.ts b/milvus/grpc/Data.ts
@@ -342,7 +342,12 @@ export class Data extends Collection {
 
     const pkField = await this.getPkFieldName(data);
 
-    const req = { ...data, expr: `${pkField} in [${data.ids.join(',')}]` };
+    // generate expr by different type of ids
+    const expr =
+      typeof data.ids[0] === "string"
+        ? `${pkField} in ["${data.ids.join('","')}"]`
+        : `${pkField} in [${data.ids.join(",")}]`;
+    const req = { ...data, expr };
     return this.deleteEntities(req);
   }