[SARC-378+SARC-353] RGU: fichiers de mapping GPU->Billing, déplacement des fichiers dans la DB, et gestion simultanée RGU + GPU billing #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eries_rgu(). Instead use client function get_available_clusters().
- load_job_series - update_job_series_rgu - compute_cost_and_waste - compute_time_frames
bouthilx
reviewed
Oct 23, 2024
sarc/client/rgu.py
Outdated
|
|
||
| cluster_name: str | ||
| rgu_start_date: datetime | ||
| gpu_to_rgu: Dict[str, float] |
There was a problem hiding this comment.
On pourrait changer ici pour mettre plutôt une version de RGU à utiliser, version qui réfère à IGUANE. Il faudrait quand même un dictionnaire pour le mapping billing -> 1 RGU, qu'on pourrait appeler rgu_billing_ratio ou qqc dans le genre. On a besoin de ça car le billing n'est pas toujours billing=100 -> 1 RGU. Par exemple, pendant un certain temps on avait billing=175 -> 1 RGU sur Narval.
…ed files. - Use IGUANE (packaged-version from a fork) to compute RGUs at runtime. - Use cached files to manage GPU billings. - Add `sarc acquire gpubillings` to import GPU billings from cached file to SARC database. - Rewrite function `update_job_series_rgu` to handle both RGU and GPU billing. - Add a script to extract GPU billings from slurm configuration files.
notoraptor
changed the title
|
@bouthilx @nurbal PR à jour ! Grosse mise à jour qui revoit de fond en comble la gestion des RGUs, avec prise en charge simultanée des RGUs et des GPU billings:
Qu'en pensez-vous? |
|
Pour le moment, je ferme cette PR-ci, puisqu'on va la découper en PRs plus petites (cf. #138 pour la prochaine à reviewer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @nurbal ! Voici une PR pour mettre les RGUs dans la base de données.
Cette PR inclut aussi la prise en charge de l'évolutivité des RGUs, donc je ferme en même temps la précédente PR #136 .