Add mymila fields #120
Open
Add mymila fields #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyaog
commented
Apr 10, 2024
Comment on lines
96
to
108
| users = get_users() | ||
| assert len(users) == nbr_users | ||
|
|
||
| for i in range(nbr_profs): | ||
| user = users[i] | ||
| # A prof should not have a supervisor or co-supervisor | ||
| assert user.mila_ldap["supervisor"] is None | ||
| assert user.mila_ldap["co_supervisor"] is None | ||
|
|
||
| for i in range(nbr_profs, nbr_users): | ||
| user = users[i] | ||
| assert user.mila_ldap["supervisor"] == f"john.smith{i%nbr_profs:03d}@mila.quebec" | ||
| assert user.mila_ldap["co_supervisor"] == f"john.smith{(i+1)%nbr_profs:03d}@mila.quebec" |
There was a problem hiding this comment.
Would this be somewhat the expected behaviour?
satyaog
force-pushed
the
feature/mymila_file
branch
from
cbf5e06
to
0e97e32
Compare
satyaog
commented
Apr 11, 2024
Comment on lines
+99
to
+105
| for i in range(nbr_profs): | ||
| user = users[i] | ||
| # A prof should not have a supervisor or co-supervisor but there's a | ||
| # mismatch between the number of profs in ldap (1) and the generated | ||
| # mymila data (5) | ||
| # assert user.mila_ldap["supervisor"] is None | ||
| # assert user.mila_ldap["co_supervisor"] is None |
There was a problem hiding this comment.
Would it be worth it to harmonize fake_raw_ldap_data with fake_mymila_data to set the number of professor to sometimes be >1? My assumption of a professor should nto have a [co-]supervisor might also be wrong?
satyaog
force-pushed
the
feature/mymila_file
branch
from
0e97e32
to
7619bb1
Compare
* membership_type * collaboration_type * affiliation
satyaog
force-pushed
the
feature/mymila_file
branch
from
5b3736c
to
23fac41
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.