Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update samp.py #135

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Update samp.py #135

merged 1 commit into from
Jun 11, 2024

Conversation

tsiedler
Copy link
Contributor

  • add upper limit for n_actives
  • break double for loop, if mask position is already occupied

@tsiedler
Update samp.py
b30e47c 
- add upper limit for n_actives
- break double for loop, if mask position is already occupied
@tsiedler
Copy link
Contributor Author

Should resolve issues #102 and #111

frankong
frankong approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@frankong frankong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonbmartin jonbmartin merged commit 5374fcc into mikgroup:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankong frankong frankong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsiedler @frankong @jonbmartin