Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for full-spoke radial trajectory #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fyrdahl
Copy link

@fyrdahl fyrdahl commented Aug 15, 2022

I noticed that the radial trajectory code defaulted to half-spoke (center-out) with no option to use full spokes, so I added that option. The default behavior doesn't change, but the new option is a closer match to what is described in the referenced papers.
The change to beta in the full-spoke 3D-radial case is not strictly necessary, but the change reflects how it's described in the original paper.

I also changed the deprecated np.float to np.float32, as I understand you prefer explicit size instead of the built-in types.

@curtcorum
Copy link

Any ideas why the checks failed? Not much info available from travis ci without a login?

@fyrdahl
Copy link
Author

fyrdahl commented Jan 11, 2023

It's a bunch of failed flake8 tests, most of which seem unrelated to this PR. The failed test which I believe is related is an E501 line too long.

./sigpy/mri/samp.py:90:80: E501 line too long (83 > 79 characters)

Since most errors are unrelated to this PR, fixing the PR itself probably won't solve the failed checks. I think PEP8 should be abided by when possible but breaking up the argument list into multiple lines is a departure from the coding style in the rest of the code base. This will probably become a bigger problem when someone gets around to fixing the deprecated datatypes, which will add 2-3 chars to every line that specifies a dtype.

@sidward
Copy link
Collaborator

sidward commented May 27, 2023

Hi, sorry -- I updated the tooling. Can you please run bash run_tests.sh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants