-
-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement video-length filter using ffprobe #6246
base: master
Are you sure you want to change the base?
Conversation
I see a few problems with this approach. The request sent by ffprobe will not have any of the headers (most importantly cookies), the retry logic is missing, and this will 'double up' every request. The proper (much more annoying to implement) way to do this would be to include ffmpeg as a library, and then do the requests in python and pass the data to the ffmpeg library. I think it might make sense to include this nearly as-is (it still does something useful), but I think it should be marked with warnings in the documentation (maybe even rename the options something like |
Thanks for the feedback. I'll look into it |
@shelvacu do you have an example link/page that explicitly requires specific headers? Thanks |
Every site that requires a login will have to send a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I hope this gets merged.
This implements two new filter options to filter videos based on their actual length before downloading them.
This fixes #4928
One interesting issue I noticed is that Motion JPEG exist. This is a video format that often only contains a single frame. Hence, I implemented the minimum frame logic.