Fix status update from background thread

mihai8804858 · Aug 1, 2024 · 7c90a26 · 7c90a26
1 parent c24ae3d
commit 7c90a26
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/Sources/PathMonitor/PathMonitorType.swift b/Sources/PathMonitor/PathMonitorType.swift
@@ -9,7 +9,7 @@ protocol PathMonitorType: Sendable {
     #endif
     var path: PathType { get }
 
-    func onPathUpdate(_ callback: @escaping (PathType) -> Void)
+    func onPathUpdate(_ callback: @escaping @Sendable (PathType) -> Void)
     func start(queue: DispatchQueue)
     func cancel()
 }

diff --git a/Sources/Reachability/Reachability.swift b/Sources/Reachability/Reachability.swift
@@ -66,11 +66,13 @@ public final class Reachability: Sendable, ObservableObject {
 extension Reachability {
     private func observeNetworkPathChanges() {
         monitor.start(queue: DispatchQueue.global(qos: .utility))
-        monitor.onPathUpdate { [weak self] path in
-            guard let self else { return }
-            status = monitor.connectionStatus(for: path)
-            isExpensive = path.isExpensive
-            isConstrained = path.isConstrained
+        monitor.onPathUpdate { path in
+            DispatchQueue.main.async { [weak self] in
+                guard let self else { return }
+                status = monitor.connectionStatus(for: path)
+                isExpensive = path.isExpensive
+                isConstrained = path.isConstrained
+            }
         }
     }
 }
diff --git a/Tests/Mocks/MockPathMonitor.swift b/Tests/Mocks/MockPathMonitor.swift
@@ -21,8 +21,8 @@ final class MockPathMonitor: PathMonitorType {
     }
     #endif
 
-    let onPathUpdateCheck = FuncCheck<(PathType) -> Void>()
-    func onPathUpdate(_ callback: @escaping (PathType) -> Void) {
+    let onPathUpdateCheck = FuncCheck<@Sendable (PathType) -> Void>()
+    func onPathUpdate(_ callback: @escaping @Sendable (PathType) -> Void) {
         onPathUpdateCheck.call(callback)
     }