Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Canonical.Ubuntu.2404 version 2404.0.5.0 #172850

Closed
wants to merge 3 commits into from
Closed

New package: Canonical.Ubuntu.2404 version 2404.0.5.0 #172850

wants to merge 3 commits into from

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Sep 11, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Dragon1573
Copy link
Contributor Author

Manually validated in Windows Sandbox.

image

Note

This package didn't shown in ARP Entries after installation. DisplayVersion and Publisher information can only be found in "Advanced" panel in "Settings > Applications > Installed Applications".

@Dragon1573
Apply suggestions from code review
6067e82 
- Update `PackageName`, since this is an LTS version
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Sep 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 11, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Sep 12, 2024
stephengillie
stephengillie requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual Validation ended with:
image

Edit: My VMs currently have an issue enabling Hyper-V or WSL. (Error 14081)

manifests/c/Canonical/Ubuntu/2404/2404.0.5.0/Canonical.Ubuntu.2404.installer.yaml Show resolved Hide resolved
@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Sep 12, 2024
@Dragon1573 @stephengillie
Apply suggestions from code review
db7df68 
- WSL is a required feature for this package.
- Add it as a dependency.

Co-authored-by: Stephen Gillie <[email protected]>
auto-merge was automatically disabled September 13, 2024 02:23

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. labels Sep 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 18, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Sep 18, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello Dragon1573,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 18, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 18, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Sep 18, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello Dragon1573,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 18, 2024
@Dragon1573
Copy link
Contributor Author

@stephengillie @ItzLevvie - This package creates SO MANY Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. .

What's wrong with the pipeline? Shall I temporarily switch this pull request as draft and wait for pipelines being recovered?

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 18, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Sep 18, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello Dragon1573,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 18, 2024
@Dragon1573
Copy link
Contributor Author

Note

Close with reason: Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. caused by unknown reason

@Dragon1573 Dragon1573 closed this Sep 18, 2024
@Dragon1573 Dragon1573 deleted the issues/172826 branch September 18, 2024 12:49
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie requested changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees

@stephengillie stephengillie

Labels
Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Moderator-Approved One of the Moderators has reviewed and approved this PR Retry-1 flag to indicate retried Validation-Retry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: Ubuntu
4 participants
@Dragon1573 @wingetbot @ItzLevvie @stephengillie