New package: GorrilaDevs.Ferium version 4.5.0 #137336

Exorcism0666 · 2024-01-31T15:46:54Z

Pull request has been created with Komac v1.11.0 🚀

Resolve: [Package Request]: GorillaDevs.Ferium #137328

Microsoft Reviewers: Open in CodeFlow

wingetbot · 2024-01-31T15:46:58Z

wingetbot · 2024-01-31T15:47:04Z

/AzurePipelines run

azure-pipelines · 2024-01-31T15:47:14Z

Azure Pipelines successfully started running 1 pipeline(s).

wingetbot · 2024-01-31T15:49:21Z

/AzurePipelines run

azure-pipelines · 2024-01-31T15:49:33Z

Azure Pipelines successfully started running 1 pipeline(s).

stephengillie · 2024-01-31T16:20:33Z

/AzurePipelines run

stephengillie · 2024-01-31T16:20:35Z

Automatic Validation ended with:

2024-01-31T15:56:45.1524192Z ##[error] One or more errors occurred. (SQL error or missing database (0x87AF0001)) SQL error or missing database (0x87AF0001)

(Automated response - build 684.)

azure-pipelines · 2024-01-31T16:20:44Z

Azure Pipelines successfully started running 1 pipeline(s).

Exorcism0666 · 2024-01-31T16:35:30Z

For moderators

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping @Exorcism0666, I'll get a notification.

Important

Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

stephengillie · 2024-02-01T02:08:56Z

Hi @Exorcism0666,

The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.

(Automated response - build 691.)

stephengillie · 2024-02-01T02:09:05Z

Automatic Validation ended with:

Installation failed with exit code -1978335187 2024-01-31 12:41:18.010 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.5.0/ferium-windows-msvc.zip Result: 0x80004005 MSI (s) (94:A4) [12:41:04:611]: Windows Installer installed the product. Product Name: Microsoft Visual C++ 2022 X64 Minimum Runtime - 14.38.33130. Product Version: 14.38.33130. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. MSI (s) (94:08) [12:41:05:767]: Windows Installer installed the product. Product Name: Microsoft Visual C++ 2022 X64 Additional Runtime - 14.38.33130. Product Version: 14.38.33130. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. [0114:15D4][2024-01-31T12:41:02]w363: Could not create system restore point, error: 0x80070422. Continuing...

(Automated response - build 691.)

stephengillie · 2024-02-01T03:07:23Z

/AzurePipelines run

azure-pipelines · 2024-02-01T03:07:33Z

Azure Pipelines successfully started running 1 pipeline(s).

stephengillie · 2024-02-01T04:09:04Z

Hi @Exorcism0666,

The package didn't pass a Defender or similar security scan. This might be a false positive and we can rescan tomorrow.

(Automated response - build 694.)

stephengillie · 2024-02-01T04:09:13Z

Automatic Validation ended with:

Installation failed with exit code -1978335187 2024-01-31 19:22:30.994 [FAIL] Installer failed security check. Url: https://github.com/gorilla-devs/ferium/releases/download/v4.5.0/ferium-windows-msvc.zip Result: 0x80004005 MSI (s) (A0:B8) [19:22:18:031]: Windows Installer installed the product. Product Name: Microsoft Visual C++ 2022 X64 Minimum Runtime - 14.38.33130. Product Version: 14.38.33130. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. MSI (s) (A0:08) [19:22:19:114]: Windows Installer installed the product. Product Name: Microsoft Visual C++ 2022 X64 Additional Runtime - 14.38.33130. Product Version: 14.38.33130. Product Language: 1033. Manufacturer: Microsoft Corporation. Installation success or error status: 0. [0508:1AD8][2024-01-31T19:22:15]w363: Could not create system restore point, error: 0x80070422. Continuing...

(Automated response - build 694.)

theRookieCoder

@Exorcism0666 just some minor nitpicks, otherwise I approve.
LGTM 👍

theRookieCoder · 2024-02-03T07:19:21Z

manifests/g/GorrilaDevs/Ferium/4.5.0/GorrilaDevs.Ferium.installer.yaml

+ReleaseDate: 2024-01-30
+Installers:
+- Architecture: x64
+  InstallerUrl: https://github.com/gorilla-devs/ferium/releases/download/v4.5.0/ferium-windows-msvc.zip


Is it possible to use the PackageVersion variable here?

If you think about future updates, the action I have linked (https://github.com/vedantmgoyal2009/winget-releaser) is able to handle that as well.

theRookieCoder · 2024-02-03T07:21:08Z

manifests/g/GorrilaDevs/Ferium/4.5.0/GorrilaDevs.Ferium.installer.yaml

+- RelativeFilePath: ferium.exe
+Dependencies:
+  PackageDependencies:
+    - PackageIdentifier: Microsoft.VCRedist.2015+.x64


Is the VS runtime actually required? If so, could I know how you determined the runtime dependencies of the executable?

For me this works without that, but I might have a different version for it from one of the games I have installed.

theRookieCoder · 2024-02-03T07:22:46Z

manifests/g/GorrilaDevs/Ferium/4.5.0/GorrilaDevs.Ferium.locale.en-US.yaml

+License: MPL-2.0
+LicenseUrl: https://github.com/gorilla-devs/ferium/blob/main/LICENSE.txt
+ShortDescription: Ferium is a fast and feature rich CLI program for downloading and updating Minecraft mods from Modrinth, CurseForge, and GitHub Releases, and modpacks from Modrinth and CurseForge.
+ReleaseNotes: |-


If markdown is supported, could we replace this with the actual changelog contents:

- Added aliases for many commands and arguments - The `--version`/`-v` flags only work for the top-level command now (they do not propagate to subcommands) - Renamed `--dont-check-game-version` and `--dont-check-mod-loader` to `--ignore-game-version` and `--ignore-mod-loader` respectively - Also added a short hand `-V` and `-M` - The previous flags still work as a hidden alias, so scripts do not have to be edited - Added `ferium profile info` and `ferium modpack info` subcommands to print information about the current profile/modpack - These are aliased to `ferium profile` and `ferium modpack` - Added `ferium profiles` and `ferium modpacks`, which are aliases to their respective list commands - Added option to temporarily ignore game version and mod loader checks and force-add the mod anyways ([#142](https://github.com/gorilla-devs/ferium/issues/142)) - Added an argument for providing a profile/modpack to switch to after deleting a profile/modpack ([#390](https://github.com/gorilla-devs/ferium/issues/390)) - Fixed errors not getting caught when adding mods (e.g. `HTTP error 404` instead of `mod does not exist`) - Moved a majority of the mod adding code to libium - Added a header with profile information in `ferium list` - Made `ferium list` display the source and mod ID first and mod name last to circumvent minor formatting issues - Added user agent to GitHub API check to make it more reliable - Added more information and coloured formatting to profile and modpack pickers (when deleting or switching) - Made the remove picker show the same information as `ferium list` but without colours - Fixed distribution denied errors not getting caught during mod resolution and causing the entire command to fail instead ([#308](https://github.com/gorilla-devs/ferium/issues/308))

ST-DDT · 2024-02-03T11:14:29Z

manifests/g/GorrilaDevs/Ferium/4.5.0/GorrilaDevs.Ferium.installer.yaml

+# Created with Komac v1.11.0
+# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.5.0.schema.json
+
+PackageIdentifier: GorrilaDevs.Ferium


Is this correct?

Suggested change

PackageIdentifier: GorrilaDevs.Ferium

PackageIdentifier: GorillaDevs.Ferium

See also: https://github.com/gorilla-devs/ferium

Oh yes that is indeed a typo

ST-DDT · 2024-02-03T11:25:50Z

Other than that the manifest works as expected for me:

where ferium
# %LOCALAPPDATA%/Microsoft/WinGet/Packages/GorrilaDevs.Ferium__DefaultSource/ferium

RokeJulianLockhart · 2024-02-03T11:32:58Z

See #137328 (comment), @Exorcism0666. Specifically, I somehow misspelt “Gorilla”.

theRookieCoder · 2024-02-03T12:41:43Z

Also I'm not sure what is up Defender flagging ferium as malicious, I've had other users report this to me too. Is it some native library I'm using? Or just the fact that it downloads a lot of files?

Exorcism0666 · 2024-02-03T17:51:17Z

@stephengillie @ST-DDT @RokeJulianLockhart I will reopen a pull request because of the typo :c

New package: GorrilaDevs.Ferium version 4.5.0

49a4570

Update GorrilaDevs.Ferium.installer.yaml

ec55e9e

wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Jan 31, 2024

microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 31, 2024

microsoft-github-policy-service bot removed Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2024

wingetbot added the Validation-Installation-Error Error installing application label Jan 31, 2024

microsoft-github-policy-service bot assigned Exorcism0666 Jan 31, 2024

microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 31, 2024

microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 31, 2024

stephengillie added the Validation-Defender-Error label Feb 1, 2024

microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Validation-Defender-Error Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 1, 2024

wingetbot added the Validation-Installation-Error Error installing application label Feb 1, 2024

microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Feb 1, 2024

stephengillie added Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Defender-Error labels Feb 1, 2024

theRookieCoder suggested changes Feb 3, 2024

View reviewed changes

microsoft-github-policy-service bot added the Changes-Requested Changes Requested label Feb 3, 2024

ST-DDT suggested changes Feb 3, 2024

View reviewed changes

Exorcism0666 closed this Feb 3, 2024

microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Feb 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New package: GorrilaDevs.Ferium version 4.5.0 #137336

New package: GorrilaDevs.Ferium version 4.5.0 #137336

Exorcism0666 commented Jan 31, 2024 •

edited by microsoft-github-policy-service bot

Loading

wingetbot commented Jan 31, 2024

wingetbot commented Jan 31, 2024

azure-pipelines bot commented Jan 31, 2024

wingetbot commented Jan 31, 2024

azure-pipelines bot commented Jan 31, 2024

stephengillie commented Jan 31, 2024

stephengillie commented Jan 31, 2024

azure-pipelines bot commented Jan 31, 2024

Exorcism0666 commented Jan 31, 2024

stephengillie commented Feb 1, 2024

stephengillie commented Feb 1, 2024

stephengillie commented Feb 1, 2024

azure-pipelines bot commented Feb 1, 2024

stephengillie commented Feb 1, 2024

stephengillie commented Feb 1, 2024

theRookieCoder left a comment

theRookieCoder Feb 3, 2024

ST-DDT Feb 3, 2024

theRookieCoder Feb 3, 2024 •

edited

Loading

ST-DDT Feb 3, 2024

theRookieCoder Feb 3, 2024

ST-DDT Feb 3, 2024 •

edited

Loading

theRookieCoder Feb 3, 2024

ST-DDT commented Feb 3, 2024

RokeJulianLockhart commented Feb 3, 2024 •

edited

Loading

theRookieCoder commented Feb 3, 2024 •

edited

Loading

Exorcism0666 commented Feb 3, 2024

	PackageIdentifier: GorrilaDevs.Ferium
	PackageIdentifier: GorillaDevs.Ferium

New package: GorrilaDevs.Ferium version 4.5.0 #137336

New package: GorrilaDevs.Ferium version 4.5.0 #137336

Conversation

Exorcism0666 commented Jan 31, 2024 • edited by microsoft-github-policy-service bot Loading

Pull request has been created with Komac v1.11.0 🚀

Microsoft Reviewers: Open in CodeFlow

wingetbot commented Jan 31, 2024

wingetbot commented Jan 31, 2024

azure-pipelines bot commented Jan 31, 2024

wingetbot commented Jan 31, 2024

azure-pipelines bot commented Jan 31, 2024

stephengillie commented Jan 31, 2024

stephengillie commented Jan 31, 2024

azure-pipelines bot commented Jan 31, 2024

Exorcism0666 commented Jan 31, 2024

For moderators

stephengillie commented Feb 1, 2024

stephengillie commented Feb 1, 2024

stephengillie commented Feb 1, 2024

azure-pipelines bot commented Feb 1, 2024

stephengillie commented Feb 1, 2024

stephengillie commented Feb 1, 2024

theRookieCoder left a comment

Choose a reason for hiding this comment

theRookieCoder Feb 3, 2024

Choose a reason for hiding this comment

ST-DDT Feb 3, 2024

Choose a reason for hiding this comment

theRookieCoder Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

ST-DDT Feb 3, 2024

Choose a reason for hiding this comment

theRookieCoder Feb 3, 2024

Choose a reason for hiding this comment

ST-DDT Feb 3, 2024 • edited Loading

Choose a reason for hiding this comment

theRookieCoder Feb 3, 2024

Choose a reason for hiding this comment

ST-DDT commented Feb 3, 2024

RokeJulianLockhart commented Feb 3, 2024 • edited Loading

theRookieCoder commented Feb 3, 2024 • edited Loading

Exorcism0666 commented Feb 3, 2024

Exorcism0666 commented Jan 31, 2024 •

edited by microsoft-github-policy-service bot

Loading

theRookieCoder Feb 3, 2024 •

edited

Loading

ST-DDT Feb 3, 2024 •

edited

Loading

RokeJulianLockhart commented Feb 3, 2024 •

edited

Loading

theRookieCoder commented Feb 3, 2024 •

edited

Loading