Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure names match #233877

Merged
merged 1 commit into from
Nov 15, 2024
Merged

make sure names match #233877

merged 1 commit into from
Nov 15, 2024

Conversation

justschen
Copy link
Contributor

the main reason we are doing this is because in copilot and copilot chat, github uses:
GitHub as the source (we create extension identifiers in core by doing source + . + extensionName), but in core the check is github.copilot-chat since that is what the extension contributes.

Screenshot 2024-11-14 at 6 02 58 PM

vs.

Screenshot 2024-11-14 at 6 02 09 PM

in any case, capitalization shouldn't matter

@justschen justschen merged commit 6075871 into microsoft:main Nov 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants