Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename asCSSPropertyValue to asCSSStringValue and use for generated CSS with font-family and content #233687

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

rename asCSSPropertyValue to asCSSStringValue and use for generated CSS with font-family and content #233687

wants to merge 3 commits into from

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Nov 12, 2024 •
edited
Loading

  • more validation on values for file-icon / product-icon themes and icon registry
  • rename asCSSPropertyValue to asCSSStringValue and use for generated CSS with font-family and content

@aeschli aeschli self-assigned this Nov 12, 2024
@aeschli aeschli enabled auto-merge (squash) November 12, 2024 14:01
@vs-code-engineering vs-code-engineering bot added this to the November 2024 milestone Nov 12, 2024
@aeschli aeschli marked this pull request as draft November 12, 2024 14:04
auto-merge was automatically disabled November 12, 2024 14:04

Pull request was converted to draft

@aeschli aeschli marked this pull request as ready for review November 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songjianet songjianet songjianet approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@aeschli @lramos15 @songjianet